Added shell parser to separate entry and args for command#1
Open
vietjtnguyen wants to merge 1 commit intosamuelson:optional_commandfrom
Open
Added shell parser to separate entry and args for command#1vietjtnguyen wants to merge 1 commit intosamuelson:optional_commandfrom
vietjtnguyen wants to merge 1 commit intosamuelson:optional_commandfrom
Conversation
Owner
|
Can you help me understand why this is needed? I think I would prefer to use a script as the command rather than add more complexity to the app itself. |
Owner
|
Also, I don't really want to merge anything until this is merged upstream. |
Author
|
It's just sort of canonically extensible. This way I can now run in my Docker container to attach to interactively inspect and check my long running process. Sure you can create a shell script but it seems a little unnecessary to me. Feel free to defer this until your current branch state is merged. |
samuelson
pushed a commit
that referenced
this pull request
Apr 20, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with a somewhat strange
node app.js -c "/bin/bash -xc \"echo hello & /bin/bash\"" -p 80and got the expected output: