Skip to content

fix(info): read indexed source stats - #139

Merged
samzong merged 2 commits into
mainfrom
feature/release-0.5-ng05
Aug 14, 2026
Merged

fix(info): read indexed source stats#139
samzong merged 2 commits into
mainfrom
feature/release-0.5-ng05

Conversation

@samzong

@samzong samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • read per-source session, message, and date-range stats from the Recall index in one grouped query
  • stop recall info from parsing every external adapter before producing output
  • remove the now-unused adapter scan_summary hook
  • align the text labels with the documented indexed-stat semantics

Verification

  • cargo test db::session_store::source_stats_tests::indexed_source_stats_use_persisted_session_counts -- --exact
  • JSON protocol shape assertion for every existing top-level and per-source field
  • make check

Production-scale probe

On the existing 4.26 GB Recall index:

  • before: no stdout after 35.17s; manually interrupted at 1.56 GB maximum RSS
  • after: 0.01-0.02s across five warmed runs; 18.8 MB maximum RSS
  • the database mtime and size remained unchanged

The JSON field names, types, and protocol/schema versions are unchanged. Source counts now consistently describe indexed data, matching the existing command help and README.

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0dadbb0840

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/info.rs Outdated
Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong

samzong commented Aug 14, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 6d286b5af0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@samzong
samzong merged commit ebbc570 into main Aug 14, 2026
3 checks passed
@samzong
samzong deleted the feature/release-0.5-ng05 branch August 14, 2026 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant