Skip to content

test(etl): stub Groups::Connector in sync_all rake test #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
billie-clawford-stacksbot wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(etl): stub Groups::Connector in sync_all rake test #139

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion test/lib/tasks/etl_rake_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,24 @@ class EtlRakeTest < ActiveSupport::TestCase
Rake::Task['stacks:etl:backfill_meet_all'].invoke('30')
end

test 'sync_all invokes sync_meet_all (api) before sync_gemini_notes_all (gemini_notes, parse_transcript: false)' do
test 'sync_all invokes sync_meet_all (api) before sync_gemini_notes_all (gemini_notes, parse_transcript: false), then sync_google_groups' do
seq = sequence('sync_all_sweeps')
Stacks::Etl::Meet.expects(:sweep_all_users!).with(has_entry(mode: :api)).in_sequence(seq)
Stacks::Etl::Meet.expects(:sweep_all_users!).with(has_entries(mode: :gemini_notes, until_time: nil, parse_transcript: false)).in_sequence(seq)
# sync_google_groups instantiates Stacks::Etl::Groups::Connector directly (no
# sweep_all_users! helper) — stub it the same way sync_meet's own test does, so
# sync_all's invocation of stacks:etl:sync_google_groups doesn't run the REAL
# connector against test fixtures. Without this, index_chunks! actually tries to
# persist a chunk's `embedding` attribute, which db/schema.rb intentionally omits
# (pgvector is added outside the dumped schema — see schema.rb's top-of-file note),
# so Heroku CI's in-dyno Postgres blows up with
# ActiveModel::UnknownAttributeError: unknown attribute 'embedding' for Embedding.
groups_connector = mock('groups_connector')
groups_connector.expects(:run).once.in_sequence(seq)
Stacks::Etl::Groups::Connector.expects(:new).with(has_entry(:admin_email)).returns(groups_connector).in_sequence(seq)
Rake::Task['stacks:etl:sync_meet_all'].reenable
Rake::Task['stacks:etl:sync_gemini_notes_all'].reenable
Rake::Task['stacks:etl:sync_google_groups'].reenable
Rake::Task['stacks:etl:sync_all'].reenable
Rake::Task['stacks:etl:sync_all'].invoke
end
Expand Down