Skip to content

add 'geometry' dependencies to 'dev'#447

Merged
jtgrasb merged 2 commits intosandialabs:mainfrom
rgcoe:dev_includes_all
Feb 16, 2026
Merged

add 'geometry' dependencies to 'dev'#447
jtgrasb merged 2 commits intosandialabs:mainfrom
rgcoe:dev_includes_all

Conversation

@rgcoe
Copy link
Contributor

@rgcoe rgcoe commented Jan 22, 2026

The optional dependencies for dev should probably include all dependencies to run all tests with no skipping, right?

@jtgrasb jtgrasb self-requested a review January 22, 2026 22:24
@coveralls
Copy link

coveralls commented Jan 22, 2026

Pull Request Test Coverage Report for Build 21265433977

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.938%

Totals Coverage Status
Change from base Build 19520260166: 0.0%
Covered Lines: 1254
Relevant Lines: 1426

💛 - Coveralls

@jtgrasb
Copy link
Collaborator

jtgrasb commented Feb 16, 2026

@rgcoe Yes, that's a good point. This should work the same as the prior workflow, since its not actually changing what's installed, just at which step geometry is included. But for installing dev and testing locally, it makes sense to include geometry by default. Merging now.

@jtgrasb jtgrasb merged commit 6f1c3d7 into sandialabs:main Feb 16, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants