future proofing the post_process method to account for missing zero frequency in wave#450
Merged
jtgrasb merged 1 commit intosandialabs:devfrom Mar 2, 2026
Merged
Conversation
Pull Request Test Coverage Report for Build 22323821097Details
💛 - Coveralls |
Collaborator
|
This looks good and I confirmed it works locally for me. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I received FutureWarnings during the merge in post_process.
The wave is always missing the zero frequency.
There is a simple fix:
join="outer" keeps the union of frequency values
compat='no_conflicts': allows “fill in missing” but no contradictions.
Further,
ifd.expand_dims({'realization':[ires]})
itd.expand_dims({'realization':[ires]})
did nothing.
Now changed so that the dimension is added before the concatenation (the concatenation actually expanded the dims)
Description
Concise description of the pull request with references to any issues.
Type of PR
Checklist for PR
Additional details
Include any relevant context and describe any validation and verification efforts.