Skip to content

future proofing the post_process method to account for missing zero frequency in wave#450

Merged
jtgrasb merged 1 commit intosandialabs:devfrom
dtgaebe:xarray_merge
Mar 2, 2026
Merged

future proofing the post_process method to account for missing zero frequency in wave#450
jtgrasb merged 1 commit intosandialabs:devfrom
dtgaebe:xarray_merge

Conversation

@dtgaebe
Copy link
Collaborator

@dtgaebe dtgaebe commented Feb 23, 2026

I received FutureWarnings during the merge in post_process.
The wave is always missing the zero frequency.

There is a simple fix:
join="outer" keeps the union of frequency values
compat='no_conflicts': allows “fill in missing” but no contradictions.

Further,
ifd.expand_dims({'realization':[ires]})
itd.expand_dims({'realization':[ires]})
did nothing.

Now changed so that the dimension is added before the concatenation (the concatenation actually expanded the dims)

Description

Concise description of the pull request with references to any issues.

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

Additional details

Include any relevant context and describe any validation and verification efforts.

@dtgaebe dtgaebe requested a review from jtgrasb February 23, 2026 20:36
@dtgaebe dtgaebe marked this pull request as ready for review February 24, 2026 16:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 22323821097

Details

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.938%

Totals Coverage Status
Change from base Build 22073734202: 0.0%
Covered Lines: 1254
Relevant Lines: 1426

💛 - Coveralls

@jtgrasb
Copy link
Collaborator

jtgrasb commented Mar 2, 2026

This looks good and I confirmed it works locally for me. Ready to merge.

@jtgrasb jtgrasb changed the base branch from main to dev March 2, 2026 16:15
@jtgrasb jtgrasb merged commit 97f924c into sandialabs:dev Mar 2, 2026
29 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants