Skip to content

Conversation

@jmgate
Copy link
Collaborator

@jmgate jmgate commented Dec 18, 2025

This reverts commit 1993c3d.

The real fix is in 1c21dd3.

Summary by Sourcery

CI:

  • Remove the explicit apt-based installation of openssh-client from the semantic-release GitHub Actions workflow.

This reverts commit 1993c3d.

The real fix is in 1c21dd3.
@jmgate jmgate self-assigned this Dec 18, 2025
@sourcery-ai
Copy link

sourcery-ai bot commented Dec 18, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR reverts the previous CI change that explicitly installed the SSH client in the semantic-release GitHub Actions workflow, relying instead on the underlying fix introduced elsewhere.

Flow diagram for updated semantic-release CI workflow

flowchart TD
    GHActions[GitHub Actions workflow semantic-release]
    Job[Job release]
    Checkout[Step actions/checkout@v4]
    SemanticRelease[Step python-semantic-release action]

    GHActions --> Job
    Job --> Checkout
    Checkout --> SemanticRelease
Loading

File-Level Changes

Change Details Files
Remove explicit installation of openssh-client from the semantic-release GitHub Actions workflow job.
  • Delete the CI step that runs apt-get update and installs openssh-client before semantic-release executes
  • Leave the rest of the semantic-release job configuration unchanged, continuing to use the existing Python Semantic Release action and checkout settings
.github/workflows/semantic-release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link

codecov bot commented Dec 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.01%. Comparing base (4ee63a3) to head (bfbe079).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   94.01%   94.01%           
=======================================
  Files           2        2           
  Lines         167      167           
  Branches       37       37           
=======================================
  Hits          157      157           
  Misses          4        4           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jmgate jmgate merged commit a03f9b4 into master Dec 18, 2025
15 checks passed
@jmgate jmgate deleted the revert-ssh-client-install branch December 18, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants