Skip to content

Y25-485 - Removing model extensions where possible#5309

Open
sabrine33 wants to merge 39 commits intodevelopfrom
Y25-485-remove-model-extensions
Open

Y25-485 - Removing model extensions where possible#5309
sabrine33 wants to merge 39 commits intodevelopfrom
Y25-485-remove-model-extensions

Conversation

@sabrine33
Copy link
Contributor

@sabrine33 sabrine33 commented Oct 27, 2025

Closes #5306

removing scope from model extensions
running spec/model/request successfully

running spec/model/request successfully
@sabrine33 sabrine33 linked an issue Oct 27, 2025 that may be closed by this pull request
6 tasks
@StephenHulme StephenHulme changed the title removing scope from model extensions Y25-485 - Removing model extensions where possible Jan 23, 2026
@StephenHulme StephenHulme force-pushed the Y25-485-remove-model-extensions branch from c21807f to d474d87 Compare February 20, 2026 14:47
@codecov
Copy link

codecov bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 84.75%. Comparing base (0897f7a) to head (3287873).

Files with missing lines Patch % Lines
app/models/order.rb 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5309      +/-   ##
===========================================
- Coverage    87.21%   84.75%   -2.46%     
===========================================
  Files         1461     1278     -183     
  Lines        33003    31412    -1591     
  Branches      3470     3440      -30     
===========================================
- Hits         28783    26623    -2160     
- Misses        4199     4769     +570     
+ Partials        21       20       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@StephenHulme
Copy link
Contributor

StephenHulme commented Mar 19, 2026

Line diff summary:

Path                                            │ Lines │ Graph
────────────────────────────────────────────────┼───────┼───────
.rubocop_todo.yml                               │   188 │ ❇️⛔
.ruby-version                                   │     2 │ ❇️⛔
Gemfile.lock                                    │    14 │ ❇️⛔
app/api/core/                                   │   566 │ ⛔⛔⛔
app/api/core/endpoint/                          │   112 │ ⛔
app/api/core/endpoint/basic_handler/            │     2 │ ❇️⛔
app/api/core/io/                                │     4 │ ⛔
app/api/core/io/base/json_formatting_behaviour/ │     2 │ ❇️⛔
app/api/core/service/                           │   222 │ ⛔⛔
app/api/                                        │     1 │ ⛔
app/api/endpoints/                              │   919 │ ⛔⛔⛔⛔⛔
app/api/endpoints/tube/                         │    11 │ ⛔
app/api/io/active_record/                       │    19 │ ⛔
app/api/io/                                     │  1376 │ ⛔⛔⛔⛔⛔⛔⛔
app/api/io/endpoints/uuids/                     │    14 │ ⛔
app/api/io/transfer/                            │   132 │ ⛔
app/api/io/tube/                                │    17 │ ⛔
app/api/model_extensions/                       │   497 │ ⛔⛔⛔
app/controllers/                                │     2 │ ⛔
app/middleware/api/                             │   329 │ ⛔⛔
app/models/accession_service/                   │     2 │ ❇️⛔
app/models/                                     │   354 │ ❇️⛔
app/models/extensions/                          │   200 │ ❇️
app/models/submission/                          │    15 │ ❇️⛔
app/models/transfer/                            │    12 │ ❇️⛔
app/validators/                                 │    11 │ ❇️⛔
config/                                         │     3 │ ⛔
features/api/                                   │  4201 │ ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
features/api/illumina_b/                        │   583 │ ⛔⛔⛔
features/api/npg/                               │    28 │ ⛔
features/api/pulldown/                          │   749 │ ⛔⛔⛔⛔
features/api/sample_manifests/                  │   364 │ ⛔⛔
features/api/searches/                          │   777 │ ⛔⛔⛔⛔
features/api/tag_qc/                            │   666 │ ⛔⛔⛔⛔
features/api/uk10k/                             │  1165 │ ⛔⛔⛔⛔⛔⛔
features/api/users/                             │    29 │ ⛔
features/submission/                            │   114 │ ⛔
features/support/                               │    63 │ ⛔
features/support/step_definitions/              │    30 │ ❇️⛔
lib/                                            │     4 │ ❇️⛔
spec/api/                                       │  2922 │ ⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔⛔
spec/api/core/                                  │    57 │ ⛔
spec/factories/                                 │     2 │ ❇️⛔
spec/models/                                    │     4 │ ❇️⛔
spec/                                           │     2 │ ⛔
spec/requests/                                  │    28 │ ⛔
spec/support/                                   │     1 │ ❇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y25-640 - Refactoring model extension files Y25-485 - Remove API v1 code from Sequencescape

2 participants