Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #5616 +/- ##
========================================
Coverage 87.22% 87.23%
========================================
Files 1461 1461
Lines 33003 33012 +9
Branches 3470 3472 +2
========================================
+ Hits 28787 28797 +10
+ Misses 4195 4194 -1
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
After discussion with @StephenHulme we decided not to abstract the wildcard/query layer to the search_behaviour class which would have added leading wildcard to all searches. This is because it would change the behaviour of some existing queries (adding wildcards) and cause issues with other queries (id queries) which is not intended in this PR. |
StephenHulme
approved these changes
Mar 20, 2026
Contributor
StephenHulme
left a comment
There was a problem hiding this comment.
Thanks for the discussion and renaming :)
…d labware leading wildcard option from All search
2762dd5 to
229728a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5581
Changes proposed in this pull request
Notes
I have added an unused
_wildcardto allfor_search_querymethods to keep the signatures the same even though its only used for Sample and Labware. It would be good to make use of this wildcard in the future as we are currently inconsistent with what is being wildcarded but that is out of scope for this story.