Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Contributor
|
No changes to documentation |
Contributor
|
Component Testing Report Updated Jul 2, 2024 10:58 PM (UTC)
|
juice49
force-pushed
the
next
branch
2 times, most recently
from
January 23, 2025 13:56
9caf5d8 to
691aad1
Compare
Contributor
|
@rexxars is this still relevant? Can you close if not? |
Member
|
As the client PR has not been merged, closing this until that is merged and linking both together |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the studio integration side of sanity-io/client#860 - see that PR for rationale.
I'll rebase/change this PR to use a regular release of the client once the above is merged and released.
The implementation works like this:
/pingroute.Timing-Allow-Originheader), which allows us to get the HTTP protocol used to access it.This is only enabled for customers with
allowDomainShardingset totrue, as well as theauth.loginMethodset totoken. This is unfortunate, but we cannot get the auth cookie set on the regular project hostname propagated, so we have to use tokens. This does introduce overhead, since all requests will have preflight requests.Note that this is a temporary workaround, while we work on a more permanent solution.
What to review
Either disable HTTP2/3 support (through browser flag or similar), or set
FORCE_DOMAIN_SHARDINGtotrueincreateAuthStoreand observe domain sharding behavior in staging. Setting theFORCE_DOMAIN_SHARDINGflag back tofalse(or re-enabling HTTP2/3) and observe that it does not use domain sharding.Testing
I realize this is missing tests. Since this is a temporary workaround, I find this acceptable for now. But if you feel strongly, shout out.
Notes for release
None. This is a silent release - we only want select customers to use this as a workaround, not a permanent solution.