fix(desktop): align collection header controls - #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Import asand collection selection controls to fixed action columns and a shared top baselineVerification
node --test apps/desktop/src/cardLayout.test.js apps/desktop/src/App.import-candidates.test.js(162 passed)npm test(280 passed)npm --workspace apps/desktop run buildcargo test -p skillbox-core --offline mutation_lock_preserves_parent_and_symlink_resolution_before_creation -- --nocapture(1 passed in the parent process and both subprocess roles)cargo clippy --workspace --all-targets --all-features --locked -- -D warningsgit diff --checkGitHub's current Rust 1.98 runner introduced
clippy::needless_late_initfor an existing mutation-lock test helper. Committest(core): satisfy current clippy lintrewrites only that test initialization without changing Rust product behavior.Visual QA
/tmp/skillbox-collection-header-alignment-collapsed-1600.png/tmp/skillbox-collection-header-alignment-expanded-1600.png/tmp/skillbox-collection-header-alignment-expanded-1000.pngNo Rust, Tauri, import-contract, release, tag, or Homebrew changes.