Refactor HSM Partition Create cmd to use repository methods

[mdrkb]

ToDo:

• Use repository method to create HSMPartitionConfig objects in DB
• Improve hsm_partition_create cmd implementation
• Add HSM partition config create cmd to barbican manage cmd

[rajivmucheli]

Hi,

is it better to move this to barbican-manage utility ? https://github.com/sapcc/barbican/blob/stable/2024.2-m3/barbican/cmd/barbican_manage.py#L619

I also have an enhancement PR : #13

[mdrkb]

Hi,

is it better to move this to barbican-manage utility ? https://github.com/sapcc/barbican/blob/stable/2024.2-m3/barbican/cmd/barbican_manage.py#L619

I also have an enhancement PR : #13

I have moved this cmd to barbican-manage utility. But I skipped the changes from the old enhancement PR as it is not complete and some of the implementations are missing.

[rajivmucheli]

this PR proposes to execute the barbican-manage utility to map the data ? instead of hsm_partition_create.py. Hope the passwords are now encrypted ? or stored as plain text in DB ?

[mdrkb]

this PR proposes to execute the barbican-manage utility to map the data ? instead of hsm_partition_create.py. Hope the passwords are now encrypted ? or stored as plain text in DB ?

@rajivmucheli The changes are mentioned in the PR description. Yes, you can create HSM partition configs in DB using the barbican-manage utility now (It's reusing the same code).
This PR doesn't address the plain text password issue. We need to discuss about that separately.

[rajivmucheli]

logic works, any reason why we create HSMCommands and not move it under SAPCommands ? any plans to add few tests here ? https://github.com/sapcc/barbican/blob/stable/2024.2-m3/barbican/tests/cmd/test_barbican_manage.py ?

[mdrkb]

@rajivmucheli The create_hsm_partition_config is already under barbican-manage sap --help SAP commands. Can you check again? I didn't change anything

[dorneanu]

Seems ok to me.