add comparison between longer and more complex passwords#8
Open
1ace wants to merge 1 commit intosashaperigo:masterfrom
Open
add comparison between longer and more complex passwords#81ace wants to merge 1 commit intosashaperigo:masterfrom
1ace wants to merge 1 commit intosashaperigo:masterfrom
Conversation
Owner
|
Awesome, thank you so much! I'm going to leave this open for the moment so I can discuss with my team, but I'll merge it later today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You'll probably want to reword this a bit, but my suggestion is to show that adding an exclamation mark at the end of a password doesn't add much (and how many people do that?!), especially compared to just making it longer by adding another word for instance.