prompts: add Sashiko review profile - #455
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
OllieinCanada
marked this pull request as ready for review
August 25, 2026 04:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project-context.mdin every review stageThis is the next independently reviewable step toward “Sashiko for Sashiko.” The existing
reviewbinary can select the profile with--prompts third_party/prompts/sashiko. Daemon prompt-directory selection remains separate plumbing in #447; this PR neither depends on that PR nor changes daemon configuration.Safety and scope
The only runtime plumbing change is one optional local-file load in
PromptRegistry::build_context(). Missingproject-context.mdremains a no-op, which preserves the generated shared context for every existing profile. The new Sashiko profile does not enable itself automatically.The profile is based on concrete Sashiko boundaries: Tokio task/channel lifecycle, Git and worktree ownership, subprocess cleanup, webhook authentication and repository URL safety, persistence/retry idempotence, provider error handling, token budgets, secret redaction, and configuration compatibility.
This PR does not change forge ingestion, NNTP, Git operations, database schemas, AI providers, review output, kernel prompts, or multi-repository behavior. It adds no dependencies and performs no remote prompt loading.
Deterministic validation
cargo fmt --all -- --check: passedcargo clippy --all-targets --all-features --release -- -D warnings: passedgit diff --check: passed