Skip to content

prompts: require proof for missing kernel symbols - #456

Open
OllieinCanada wants to merge 1 commit into
sashiko-dev:mainfrom
OllieinCanada:fix/439-kernel-symbol-resolution
Open

prompts: require proof for missing kernel symbols#456
OllieinCanada wants to merge 1 commit into
sashiko-dev:mainfrom
OllieinCanada:fix/439-kernel-symbol-resolution

Conversation

@OllieinCanada

Copy link
Copy Markdown
Contributor

Fixes #439

Summary

Require concrete source and build evidence before a kernel review reports that a referenced symbol does not exist.

Root cause

The git_grep summary added for #357 makes whole-tree matches visible, but #439 shows that presentation alone is not sufficient: the reviewer still claimed two mbcache functions were absent despite clear declarations, definitions, exports, and callers in the supplied results.

This adds a narrow verification boundary to the existing kernel false-positive guide:

  • search the exact identifier across the complete review worktree
  • inspect declarations, definitions, and exports before asserting absence
  • distinguish a genuinely missing symbol from a missing include, Kconfig/Makefile exclusion, or module-linkage problem
  • require the exact configuration and build/link path for configuration-dependent findings
  • treat an unavailable, failed, or incomplete search as insufficient evidence rather than proof of absence

The output checklist makes the evidence auditable without globally suppressing real undefined-symbol findings.

Scope

Only third_party/prompts/kernel/false-positive-guide.md changes. The grep tool, review pipeline, prompt bundle code, tests, and REVISION file are unchanged. No LLM-backed regression test is added.

Validation

Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive LOW issue: undefined calls to mb_cache_entry_delete_or_get() and mb_cache_entry_wait_unused()

1 participant