prompts: require proof for missing kernel symbols - #456
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #439
Summary
Require concrete source and build evidence before a kernel review reports that a referenced symbol does not exist.
Root cause
The
git_grepsummary added for #357 makes whole-tree matches visible, but #439 shows that presentation alone is not sufficient: the reviewer still claimed two mbcache functions were absent despite clear declarations, definitions, exports, and callers in the supplied results.This adds a narrow verification boundary to the existing kernel false-positive guide:
The output checklist makes the evidence auditable without globally suppressing real undefined-symbol findings.
Scope
Only
third_party/prompts/kernel/false-positive-guide.mdchanges. The grep tool, review pipeline, prompt bundle code, tests, andREVISIONfile are unchanged. No LLM-backed regression test is added.Validation
ext4_dir_rec_len(1, NULL)" #357 and False positive LOW issue: undefined calls tomb_cache_entry_delete_or_get()andmb_cache_entry_wait_unused()#439 examplescargo fmt --all -- --checkpassesgit diff --checkpasses