fix(policy): preserve original DataToVerify bytes on commit#40
Merged
Conversation
Sign #2 verifies the policy signature against the raw bytes of section 0 of the policy. Re-serializing via policy.toBytes() rebuilds section 0 from fields (PolicyParameters Map order, enum casing, length-prefix encoding) and can byte-differ from what the ORK signed in Sign #1, which causes "Policy signature could not be verified" on later signs. Compose the stored policyData as TideMemory([ DataToVerify, signature ]) using the exact bytes from request.draft so section 0 is byte-identical to what the ORK signed.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
policy.toBytes()when committing to storage; this rebuilds section 0 from fields and can byte-differ from what the ORK actually signed (PolicyParameters Map order, enum casing, length-prefix encoding).policyData = TideMemory([ DataToVerify, signature ])using the exact bytes fromrequest.draftso section 0 is byte-identical to what was signed in Sign tidecloak sdk integration #1.Why
PolicyAuthorizationFlow.AuthorizeAsyncon the ORK verifiesPolicy.Signatureagainst the raw bytes ofPolicy.DataToVerify(the input section 0, preserved). When section 0 drifts on round-trip, Sign #2 fails with "Policy signature could not be verified" while Sign #1 (Doken:1 flow) still succeeds. This change makes the bytes stored at commit time match the bytes the ORK signed.Test plan
Composed signed policy: dtv=<N>B sig=64B total=<M>B