debug(policy): emit [PolicyTrace USE] from /committed/:roleId endpoint#44
Open
sashyo wants to merge 1 commit into
Open
debug(policy): emit [PolicyTrace USE] from /committed/:roleId endpoint#44sashyo wants to merge 1 commit into
sashyo wants to merge 1 commit into
Conversation
…endpoint too After PR #42 the client fetches via /api/ssh-policies/committed/:roleId instead of the legacy /for-ssh-user/. The USE trace was only on the legacy endpoint, so a fresh round-trip after #42 produced no server-side USE line to compare against SIGN/ATTACH. Add the same trace to the new endpoint so all three logs appear on every fetch.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After PR #42 the SSH connect path fetches via the gateway-qualified
/api/ssh-policies/committed/:roleIdendpoint, but the[PolicyTrace USE]log was only on the legacy/for-ssh-user/:sshUserroute. So fresh round-trips after #42 produce no server-side USE line to compare against SIGN/ATTACH — making it impossible to confirm bytes match end-to-end with logs alone.Add the same trace to the new endpoint.
Test plan