Update ZEROS007 diagnostic to report on bool property types - #83
Update ZEROS007 diagnostic to report on bool property types#83google-labs-jules[bot] wants to merge 5 commits into
Conversation
Update ZEROS007 to report an info diagnostic on bool property type syntax locations recommending flags enum (byte) to reduce payload size. Remove obsolete ZEROS007 check for blittable-compatible nested structs.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| "Nested struct can use faster Blittable serialization", | ||
| "Nested struct '{0}' can use StructLayout(LayoutKind.Sequential, Pack = 1) to improve serialization performance with raw payload serialization", | ||
| "Use flags enum to reduce payload size", | ||
| "Property '{0}' uses bool type; consider using a flags enum (byte) to reduce payload size", |
There was a problem hiding this comment.
| "Property '{0}' uses bool type; consider using a flags enum (byte) to reduce payload size", | |
| "Property '{0}' uses bool type; consider using a flags enum (byte) to reduce payload size by combining up to 8 booleans into one byte", |
There was a problem hiding this comment.
Updated the message for ZEROS007 as suggested.
Expand ZEROS007 diagnostic message to clarify payload size reduction by combining up to 8 booleans into one byte.
Expand ZEROS007 diagnostic message to clarify payload size reduction by combining up to 8 booleans into one byte.
Clean up duplicate GetPropertyTypeLocation method in ZeroSerializerGenerator.cs that was introduced during rebase.
Update ZEROS007 to report an info diagnostic on bool property type syntax locations recommending flags enum (byte) to reduce payload size. Remove obsolete ZEROS007 check for blittable-compatible nested structs.
1 participant
Updated ZEROS007 diagnostic to target bool property type syntax locations with Info severity, suggesting flags enum (byte) to reduce payload size. Removed obsolete ZEROS007 check for blittable-compatible nested structs.
PR created automatically by Jules for task 4232139644015862881 started by @sator-imaging