Add roundtrip test for Foo and Bar structs by google-labs-jules[bot] · Pull Request #87 · sator-imaging/ZeroSerializer

google-labs-jules · 2026-08-20T10:28:03Z

Adds a roundtrip unit test for Foo and Bar structs decorated with [StructLayout(LayoutKind.Sequential, Pack = 1)] and [ZeroSerializer], verifying hardcoded byte lengths (3 and 30) and roundtrip serialization correctness.

PR created automatically by Jules for task 6948808545237087535 started by @sator-imaging

- Define Foo and Bar structs with [StructLayout(LayoutKind.Sequential, Pack = 1)] and [ZeroSerializer] attributes in SerializationModels.cs. - Add SequentialPackOneFooBarRoundTrip test in SerializationTests.cs verifying exact hardcoded byte lengths (3 for BarView and 30 for FooView) and verifying roundtrip data integrity.

google-labs-jules · 2026-08-20T10:28:05Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

sator-imaging · 2026-08-20T10:42:29Z

+    public Bar G { get; set; }
+    public Bar H { get; set; }


Suggested change

public Bar G { get; set; }

public Bar H { get; set; }

public byte G { get; set; }

public Bar H { get; set; }

public Bar I { get; set; }

Applied the suggested shape update to Foo in SerializationModels.cs and updated SequentialPackOneFooBarRoundTrip in SerializationTests.cs accordingly.

- Updated Foo struct in SerializationModels.cs to include byte property G and Bar properties H and I as suggested in PR review. - Updated SequentialPackOneFooBarRoundTrip in SerializationTests.cs to check expected byte lengths (3 for BarView and 31 for FooView) and full roundtrip serialization.

sator-imaging · 2026-08-20T10:45:35Z

+
+[StructLayout(LayoutKind.Sequential, Pack = 1)]
+[ZeroSerializer]
+public struct Foo


Suggested change

public struct Foo

public struct BadAlignedStructWithPackOne

Rename Bar and test method name also.

Renamed Bar to BadAlignedStructWithPackOne and updated test method name to BadAlignedStructWithPackOneRoundTrip as requested.

rename both Foo and Bar.

Renamed Foo to BadAlignedContainerStructWithPackOne and Bar to BadAlignedStructWithPackOne as requested.

- Renamed Bar struct to BadAlignedStructWithPackOne in SerializationModels.cs and updated Foo struct properties H and I accordingly. - Renamed test method to BadAlignedStructWithPackOneRoundTrip in SerializationTests.cs.

- Renamed Foo to BadAlignedContainerStructWithPackOne and Bar to BadAlignedStructWithPackOne in SerializationModels.cs and updated SerializationTests.cs accordingly.

sator-imaging · 2026-08-20T21:32:39Z

+
+[StructLayout(LayoutKind.Sequential, Pack = 1)]
+[ZeroSerializer]
+public struct BadAlignedContainerStructWithPackOne


Suggested change

public struct BadAlignedContainerStructWithPackOne

public struct BadlyAlignedContainerStructWithPackOne

Renamed to BadlyAlignedContainerStructWithPackOne.

sator-imaging · 2026-08-20T21:32:57Z


+[StructLayout(LayoutKind.Sequential, Pack = 1)]
+[ZeroSerializer]
+public struct BadAlignedStructWithPackOne


Suggested change

public struct BadAlignedStructWithPackOne

public struct BadlyAlignedStructWithPackOne

Renamed to BadlyAlignedStructWithPackOne.

- Renamed BadAlignedStructWithPackOne to BadlyAlignedStructWithPackOne and BadAlignedContainerStructWithPackOne to BadlyAlignedContainerStructWithPackOne as record structs. - Added Materialize equality assertion (foo == view.Materialize()) to BadlyAlignedStructWithPackOneRoundTrip in SerializationTests.cs.

sator-imaging · 2026-08-20T22:43:26Z

+            I = new BadlyAlignedStructWithPackOne { A = 0xCD, B = -4321 }
+        };
+
+        var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength];


Suggested change

var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength];

var array = new BadlyAlignedContainerArrayStructWithPackOne();

array.Values = new[] { default, foo, default };

var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength * 3];

Added BadlyAlignedContainerArrayStructWithPackOne model and updated array buffer setup.

sator-imaging · 2026-08-20T22:46:41Z

+
+        TestAssert.Equal(31, writtenBytes, nameof(writtenBytes));
+
+        var view = new BadlyAlignedContainerStructWithPackOneView(buffer);


Suggested change

var view = new BadlyAlignedContainerStructWithPackOneView(buffer);

var second = buffer.AsMemory().Slice(BadlyAlignedContainerStructWithPackOneView.RequiredByteLength, BadlyAlignedContainerStructWithPackOneView.RequiredByteLength)

var view = new BadlyAlignedContainerStructWithPackOneView(second);

Updated view initialization to slice directly from memory offset.

sator-imaging · 2026-08-20T22:50:22Z

+        var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength];
+        int writtenBytes = foo.Serialize(buffer);
+
+        TestAssert.Equal(31, writtenBytes, nameof(writtenBytes));


Suggested change

TestAssert.Equal(31, writtenBytes, nameof(writtenBytes));

TestAssert.Equal(93, writtenBytes, nameof(writtenBytes));

var arrayView = new BadlyAlignedContainerArrayStructWithPackOne(buffer);

TestAssert.True(arrayView.Values[0] == default, "1st item");

TestAssert.True(arrayView.Values[2] == default, "3rd item");

Updated array assertions in BadlyAlignedStructWithPackOneRoundTrip.

…test - Added BadlyAlignedContainerArrayStructWithPackOne model in SerializationModels.cs. - Updated BadlyAlignedStructWithPackOneRoundTrip in SerializationTests.cs to test array serialization and memory slicing as requested in PR review.

sator-imaging reviewed Aug 20, 2026

View reviewed changes

google-labs-jules Bot added 2 commits August 20, 2026 10:46

Rename Bar struct to BadAlignedStructWithPackOne per PR review

cbfca14

- Renamed Bar struct to BadAlignedStructWithPackOne in SerializationModels.cs and updated Foo struct properties H and I accordingly. - Renamed test method to BadAlignedStructWithPackOneRoundTrip in SerializationTests.cs.

Rename Foo and Bar struct models per PR review

965f586

- Renamed Foo to BadAlignedContainerStructWithPackOne and Bar to BadAlignedStructWithPackOne in SerializationModels.cs and updated SerializationTests.cs accordingly.

sator-imaging reviewed Aug 20, 2026

View reviewed changes

	public struct BadAlignedContainerStructWithPackOne
	public struct BadlyAlignedContainerStructWithPackOne

	public struct BadAlignedStructWithPackOne
	public struct BadlyAlignedStructWithPackOne

-        var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength];
+        var array = new BadlyAlignedContainerArrayStructWithPackOne();
+        array.Values = new[] { default, foo, default };
+        var buffer = new byte[BadlyAlignedContainerStructWithPackOneView.RequiredByteLength * 3];


		TestAssert.Equal(31, writtenBytes, nameof(writtenBytes));

		var view = new BadlyAlignedContainerStructWithPackOneView(buffer);

	var view = new BadlyAlignedContainerStructWithPackOneView(buffer);
	var second = buffer.AsMemory().Slice(BadlyAlignedContainerStructWithPackOneView.RequiredByteLength, BadlyAlignedContainerStructWithPackOneView.RequiredByteLength)
	var view = new BadlyAlignedContainerStructWithPackOneView(second);

-        TestAssert.Equal(31, writtenBytes, nameof(writtenBytes));
+        TestAssert.Equal(93, writtenBytes, nameof(writtenBytes));
+        var arrayView = new BadlyAlignedContainerArrayStructWithPackOne(buffer);
+        TestAssert.True(arrayView.Values[0] == default, "1st item");
+        TestAssert.True(arrayView.Values[2] == default, "3rd item");

Conversation

google-labs-jules Bot commented Aug 20, 2026

Uh oh!

google-labs-jules Bot commented Aug 20, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

google-labs-jules Bot Aug 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant