Open
Conversation
Owner
|
Hi @n0op3, Apologies for such a delay in reviewing this and thanks for your work. I think this looks like a great approach. I'm happy for you to add the debugging in - I think the background listener process is especially important to capture with the debugging judging from some recent issues. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello everyone,
I was trying to lay a simple foundation for the debugging feature mentioned in the README under the Contributing paragraph, specifically I added the --debug flag, and created a function to log debug messages to the log file if the flag was used to run clipse.
I thought I would rather ask for feedback (especially from @savedra1 of course) on the code structure before introducing any debug printing itself. It's just a couple lines of code, so hopefully it is not a hassle for anyone.
If it looks good, I (or someone else, if anyone wishes so) can go ahead and introduce some debugging prints to the codebase.
Thanks in advance!