ci: fix broken vnu download and linkedin link-check 404#2
Merged
Conversation
…kedin The vnu install was downloading from github.com/validator/validator/releases/latest/download/vnu.jar_dist.zip, which 404s — the validator project does not publish GitHub releases, only tags. The download has been broken since at least 2026-04-25. Switch to the official vnu-jar npm package (currently v26.4.16, published 2026-04-16). It bundles vnu.jar directly and lives at a stable known path under node_modules. No more apt install of default-jre either — ubuntu-latest runners ship with Java preinstalled. Also exclude linkedin.com from the lychee link checker. LinkedIn returns 404 for unauthenticated profile fetches, so the legitimate footer link to linkedin.com/in/savvides was failing CI on every PR that touched index.html. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both CI jobs ("Validate HTML" and "Check Links") have been red on
mainsince at least the v2.1.0 docs sync (2026-04-25). Two unrelated infra issues, both fixed here in one workflow file.Validate HTML
Was downloading vnu from:
The validator project doesn't publish GitHub Releases (only tags), so the URL 404s and
unzipexits 9 before vnu ever runs. Confirmed viagh api repos/validator/validator/releasesreturning[].Replaced with the official
vnu-jarnpm package (v26.4.16, published 2026-04-16 by the same project). It bundlesvnu.jarand exposes it at a stable path:node_modules/vnu-jar/build/dist/vnu.jar. Verified locally thatnpm install --no-save vnu-jarlands the jar at exactly that path. Also dropped the apt install ofdefault-jrebecause ubuntu-latest runners ship with Java preinstalled.Check Links
The lychee link checker hits
https://www.linkedin.com/in/savvides/(legitimate footer link added in7df0451) and gets a 404 because LinkedIn returns 404 for unauthenticated profile requests from non-browser user agents. Added--exclude linkedin.comto the lychee args.Diff
Test plan
mainshows green CI for the first time since v2.1.0.🤖 Generated with Claude Code