better angular integration#2
Open
regnete wants to merge 3 commits into
Open
Conversation
- always execute a callback, even if none has been specified to force angular model sync - setup Swipe instance via $timeout to let nested directives finisch their dom manipulations before the instance is created. e.g. this allows usage of ng-repeat inside swiper
|
I tried this out, because i had problems using ng-repeats within the swipe. With this it (nearly) works, but it seems the repeat loop is performed twice and doubles the swipes' tabs. Any idea? |
|
Ahhh, that's current swipe behaviour if there are only 2 tabs present. https://github.com/bradbirdsall/Swipe/pull/330 So everything fine here. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the angular-swipe implementation. While integrating it in a phonegap app if found several points worth an enhancement:
angular model sync
their dom manipulations before the instance is created. e.g. this allows
usage of ng-repeat inside swiper