Release rbi 1.0.1#58
Conversation
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
==========================================
- Coverage 97.34% 97.06% -0.28%
==========================================
Files 17 17
Lines 1735 1740 +5
==========================================
Hits 1689 1689
- Misses 46 51 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Patch release prep for rbi 1.0.1, focusing on more robust handling of character columns (by normalizing them to factors) when writing/attaching sparse NetCDF input data, plus standard CRAN/release housekeeping.
Changes:
- Normalize character columns to factors when writing NetCDF data (
bi_write()) and whenlibbi()processes list-basedinit/input/obsoptions. - Release housekeeping: bump version/roxygen note, update NEWS/CRAN comments, ignore
.claude, refresh GitHub Actions checkout versions, and fix a vignette URL.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
R/bi_write.R |
Adds internal helpers to gather character levels and factorise character columns before writing NetCDF. |
R/libbi.R |
Ensures list-based file options have consistent factor levels; tweaks attach_data() time guessing behavior; removes explicit return() usage in several places. |
man/get_char_levels.Rd |
New internal documentation for get_char_levels(). |
man/factorise.Rd |
New internal documentation for factorise(). |
NAMESPACE |
Adds missing stats::na.omit import. |
NEWS.md |
Updates release notes for 1.0.1. |
DESCRIPTION |
Bumps package version to 1.0.1 and updates RoxygenNote. |
vignettes/rbi.Rmd |
Updates a NetCDF URL. |
cran-comments.md |
Updates test environment reporting for CRAN submission. |
.Rbuildignore |
Adds .claude to build ignore list. |
.github/workflows/test-coverage.yaml |
Updates actions/checkout/upload-artifact to v4. |
.github/workflows/render_readme.yml |
Updates actions/checkout to v4. |
.github/workflows/lint_changed_files.yaml |
Updates actions/checkout to v4. |
.github/workflows/_pkgdown.yml |
Updates actions/checkout to v4. |
.github/workflows/R-CMD-check.yaml |
Updates actions/checkout to v4. |
.github/workflows/R-CMD-check-docker.yaml |
Updates actions/checkout to v4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
WalkthroughThis PR prepares the RBi package for release 1.0.1, updating package metadata and dependencies, enhancing error handling in the LibBi runner, refactoring function returns, and documenting character column handling improvements in sparse data processing. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@NEWS.md`:
- Around line 1-4: Add a second changelog bullet under "rbi 1.0.1" documenting
the dimension-ordering bug fix: state that the ordering of dimensions when
writing init files for multi-dimensional parameters during chaining was
corrected (i.e., fixed initialization file dimension ordering for chained
sampling), and reference the associated issue/PR number if available so users
see both fixes in the release notes.
🧹 Nitpick comments (2)
cran-comments.md (1)
2-4: Test environments updated appropriately for the submission.The environments cover macOS (local + CI) and Windows (win-builder devel), which is a reasonable spread. Consider whether adding a Linux environment entry (e.g., from the R-CMD-check GitHub Actions workflow) would strengthen the CRAN submission, since the CI clearly runs on
ubuntu-latestas well.R/bi_write.R (1)
499-514: Minor:factorisemodifiesvariablesin a loop over column names—consider potential redundant iterations.When multiple columns need factorisation,
lapplyover alldata_framesruns for each column innames(levels). If a given data frame has many columns to convert, eachlapplypass rewrites the entire list. For typical LibBi usage with a small number of factor columns this is fine, but be aware it's O(cols × data_frames) list replacements.The logic itself is correct—the
col %in% colnames(df)guard safely skips data frames that don't contain the column.
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
…m bug Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Co-authored-by: sbfnk-bot <242615673+sbfnk-bot@users.noreply.github.com>
Patch release fixing character column handling in sparse input data.
Closes #55, closes #57.
Changes
na.omitimport to NAMESPACE.claudeto.Rbuildignorecran-comments.mdfor current test environments