Assert the fragile seams: patches, pins, dSYMs and binding drift - #1
Merged
Merged
Conversation
sbokatuk
commented
Jul 24, 2026
Owner
- BuildXcFrameworks.sh: every pbxproj patch now asserts it either changed something or found the already-patched state, and fails naming the patch that missed - so an upstream project-file reformat breaks the patch step with a clear message instead of the archive step with a cryptic one. DatadogOtelVersion is verified against the cloned tag's Cartfile.resolved, closing the second manually-synced pin.
- Keep the dSYMs: built into libs/dsyms, cached with the frameworks, uploaded as a CI artifact and attached to every GitHub release - the only symbolication data these Catalyst binaries will ever have, previously discarded with the temp directory.
- Enforce the verbatim-copy invariant: SyncBindingsFromiOS.sh records the DatadogNet.iOS commit it copied from (build/ios-bindings-source.txt), and CI's binding-drift job re-runs the sync against exactly that commit and fails on any difference. shims/ stays outside the sync deliberately; the script's header says what must happen if the iOS Flags shim ever ships.
- Sync the binding sources from DatadogNet.iOS@07ce7ed (DDLogger nullability rationale, entry-type doc summaries) and enable the trim/AOT analyzers, matching the iOS repository.
- Pack docs/release-notes into PackageReleaseNotes; fail CI when README versions drift from Directory.Build.props.
- Fix the stale iOS-specific comments in the copied tooling (merge-packages.py, select-xcode, BuildNugets.sh), each now marked as a keep-in-sync copy.
- Document the net8 sunset: dropped in the first release after .NET 8 leaves support on 10 November 2026, in step with DatadogNet.iOS.
- BuildXcFrameworks.sh: every pbxproj patch now asserts it either changed something or found the already-patched state, and fails naming the patch that missed - so an upstream project-file reformat breaks the patch step with a clear message instead of the archive step with a cryptic one. DatadogOtelVersion is verified against the cloned tag's Cartfile.resolved, closing the second manually-synced pin. - Keep the dSYMs: built into libs/dsyms, cached with the frameworks, uploaded as a CI artifact and attached to every GitHub release - the only symbolication data these Catalyst binaries will ever have, previously discarded with the temp directory. - Enforce the verbatim-copy invariant: SyncBindingsFromiOS.sh records the DatadogNet.iOS commit it copied from (build/ios-bindings-source.txt), and CI's binding-drift job re-runs the sync against exactly that commit and fails on any difference. shims/ stays outside the sync deliberately; the script's header says what must happen if the iOS Flags shim ever ships. - Sync the binding sources from DatadogNet.iOS@07ce7ed (DDLogger nullability rationale, entry-type doc summaries) and enable the trim/AOT analyzers, matching the iOS repository. - Pack docs/release-notes into PackageReleaseNotes; fail CI when README versions drift from Directory.Build.props. - Fix the stale iOS-specific comments in the copied tooling (merge-packages.py, select-xcode, BuildNugets.sh), each now marked as a keep-in-sync copy. - Document the net8 sunset: dropped in the first release after .NET 8 leaves support on 10 November 2026, in step with DatadogNet.iOS. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Version bump, README pins to match (now CI-enforced), the curated release notes - the first surfaced on nuget.org through PackageReleaseNotes - and the binding-drift pin advanced to the committed DatadogNet.iOS HEAD. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.