Update manifest for standalone PWA#43
Conversation
seeing if change is propagated to previously installed PWA versions of the app
This reverts commit b9fbb31.
seeing if change is propagated to previously installed PWA versions of the app
|
maybe we should come up with a new domain/name for this and just have it be the "pwa wallet"? Get it into the wild and use it on some phones, without overwriting how we already use the punkwallet.io I have instantwallet.io maybe we could deploy this there? |
|
Sure, down to keep it isolated from the current domain... And @austintgriffith, that quick test of just changing some text did propagate to the PWA I have installed. I'll revert it back to the usual text. And an aside, am I missing a way to toggle light/dark mode on PunkWallet as is? If so, I'm happy to put up a separate PR that brings this back for users. I played around with it locally and deployed the initial test of this with dark mode enabled... worth noting that when I reverted those commits, the changes propagated as well, but there seems to still be a cookie stuck telling parts of the app to use the dark theme. If we had a button available to toggle this shouldn't be an issue. |
This reverts commit 3a8cc19.
|
@wackerow @austintgriffith why we haven't merged this PR yet? this seems a good way to install app on mobile phone. I have punk wallet android app installed via google play store but since that does not get updated frequently, it did not work or newer networks. If we merge this we could use same that has more latest code then published android app, user can install this on mobile. Also we can use Trusted web activity (TWA) to wrap this PWA and publish the APK on play store. |
Issue being addressed
This wallet is a great option to instantly onboard users with a new Ethereum account, simply by going to a website. One downside with the current approach is the risk of losing the private key stored in locale storage, either from the user clearing website data, or the data automatically being cleared from the browser after a certain amount of time. This can result in potential loss-of-funds if steps are not first taken to back up this key, or migrate to a more permanent wallet solution.
Proposed solution
Using the web manifest file we can enable a
standaloneprogressive web app (PWA). This allows users on certain browsers/devices to "install" the web app as a standalone application.I have been testing this branch out using an iPhone with Safari. Using a preview deploy at https://punkwallet.netlify.app/ I used the "share" button in mobile Safari and then "Add to Home Screen." I sent some Goerli ETH to the address I was presented with, and then tried a few tests:
None of the above have caused any issues (iPhone + Safari), and so far the address remains the same, and my balance is still showing correctly.
PR updates
manifest.jsonfile to use"display": "standalone",and also added higher-resolution image assets and screenshot previews for the PWA.Additional notes
If desired, we could try to add a callout to help clarify for users how this works.