Skip to content

feat: Make ix_tasks_metadata_gin index creation concurrent #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenairhodesScale merged 1 commit into from
May 13, 2026
Merged

feat: Make ix_tasks_metadata_gin index creation concurrent #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .../migrations/alembic/versions/2026_05_04_1111_add_tasks_metadata_gin_index_e9c4ff9e6542.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,13 @@


def upgrade() -> None:
op.execute(
"CREATE INDEX IF NOT EXISTS ix_tasks_metadata_gin "
"ON tasks USING GIN (task_metadata jsonb_path_ops)"
)
with op.get_context().autocommit_block():
op.execute(
"CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_tasks_metadata_gin "
"ON tasks USING GIN (task_metadata jsonb_path_ops)"
)


def downgrade() -> None:
Comment on lines 19 to 27
Copy link
Copy Markdown

@greptile-apps greptile-apps Bot May 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 PostgreSQL forbids CREATE INDEX CONCURRENTLY (and DROP INDEX CONCURRENTLY) inside a transaction block. env.py sets transaction_per_migration=True, which wraps every migration in its own BEGIN/COMMIT, so calling op.execute("CREATE INDEX CONCURRENTLY …") directly will immediately raise ERROR: CREATE INDEX CONCURRENTLY cannot run inside a transaction block and abort the migration. The newer sibling migration a9959ebcbe98 (which also has down_revision = 'e9c4ff9e6542') correctly wraps its CONCURRENTLY statements in with op.get_context().autocommit_block(): — the same pattern documented in env.py's own inline comment. Both upgrade() and downgrade() need the same fix here.

Suggested change
def upgrade() -> None:
op.execute(
"CREATE INDEX IF NOT EXISTS ix_tasks_metadata_gin "
"ON tasks USING GIN (task_metadata jsonb_path_ops)"
)
with op.get_context().autocommit_block():
op.execute(
"CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_tasks_metadata_gin "
"ON tasks USING GIN (task_metadata jsonb_path_ops)"
)
def downgrade() -> None:
def upgrade() -> None:
with op.get_context().autocommit_block():
op.execute(
"CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_tasks_metadata_gin "
"ON tasks USING GIN (task_metadata jsonb_path_ops)"
)
def downgrade() -> None:
with op.get_context().autocommit_block():
op.execute("DROP INDEX CONCURRENTLY IF EXISTS ix_tasks_metadata_gin")
Prompt To Fix With AI 
This is a comment left during a code review.
Path: agentex/database/migrations/alembic/versions/2026_05_04_1111_add_tasks_metadata_gin_index_e9c4ff9e6542.py
Line: 19-27

Comment:
PostgreSQL forbids `CREATE INDEX CONCURRENTLY` (and `DROP INDEX CONCURRENTLY`) inside a transaction block. `env.py` sets `transaction_per_migration=True`, which wraps every migration in its own `BEGIN`/`COMMIT`, so calling `op.execute("CREATE INDEX CONCURRENTLY …")` directly will immediately raise `ERROR: CREATE INDEX CONCURRENTLY cannot run inside a transaction block` and abort the migration. The newer sibling migration `a9959ebcbe98` (which also has `down_revision = 'e9c4ff9e6542'`) correctly wraps its CONCURRENTLY statements in `with op.get_context().autocommit_block():` — the same pattern documented in `env.py`'s own inline comment. Both `upgrade()` and `downgrade()` need the same fix here.

```suggestion
def upgrade() -> None:
    with op.get_context().autocommit_block():
        op.execute(
            "CREATE INDEX CONCURRENTLY IF NOT EXISTS ix_tasks_metadata_gin "
            "ON tasks USING GIN (task_metadata jsonb_path_ops)"
        )

def downgrade() -> None:
    with op.get_context().autocommit_block():
        op.execute("DROP INDEX CONCURRENTLY IF EXISTS ix_tasks_metadata_gin")
```

How can I resolve this? If you propose a fix, please make it concise.

Fix in Cursor Fix in Claude Code Fix in Codex

op.execute("DROP INDEX IF EXISTS ix_tasks_metadata_gin")
with op.get_context().autocommit_block():
op.execute("DROP INDEX CONCURRENTLY IF EXISTS ix_tasks_metadata_gin")
Loading