feat(i18n): add French translation#905
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughWalkthroughAdds French localization: seven new i18n JSON resource files (menus, buttons, common, dialogs, table, titles, tooltips) and registers French ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@assets/i18n/fr/Common.json`:
- Line 78: The French translation keys are misnamed: replace the
incorrect/duplicate keys "PreRequisite" and "PreRequiste" with the exact source
lookup key "PreRequisite:" (including the trailing colon) so the translator will
match the English lookup; update all occurrences (including the other instance
noted) to use the exact key "PreRequisite:" and remove the misspelled
"PreRequiste" entry, keeping the French value "Prérequis".
- Around line 1-134: The French i18n file has inconsistent keys: change the
"PreRequisite" key to match the English key "PreRequisite:" (include the
trailing colon) and remove the duplicate/misspelled "PreRequiste" entry; ensure
only a single "PreRequisite:" key remains with the correct translated value and
no other duplicate keys exist (check occurrences of "PreRequisite",
"PreRequisite:", and "PreRequiste" and normalize to "PreRequisite:").
In `@assets/i18n/fr/Dialog.json`:
- Line 14: Remove the stray leading apostrophe in the value for the key
"ProjectSannedPreviousVersionQuestion" so the string begins with the opening
quote only, and update the "UpdateFinished" value to a correct finished-state
translation (e.g., replace "en cours" with "terminé" or another appropriate
finished wording) to reflect completion; edit the values for the keys
"ProjectSannedPreviousVersionQuestion" and "UpdateFinished" in the JSON
accordingly.
In `@assets/i18n/fr/Table.json`:
- Around line 21-24: The translation keys "Strength " and "Dependencies " in the
Table.json language files include trailing spaces causing lookup mismatches;
open each Table.json (en, es, fr and check jp, zh) and remove the trailing
whitespace so the keys become "Strength" and "Dependencies", update any
occurrences found by searching the repo for the exact strings "Strength " and
"Dependencies " and replace them with the trimmed versions, and validate the
JSON files after edits to ensure no syntax errors.
In `@assets/i18n/fr/Tooltip.json`:
- Line 38: The translation for the key "CopyFilePath" is incorrect (it currently
reads "Rechercher dans le fichier"); update the value for the "CopyFilePath" key
in assets/i18n/fr/Tooltip.json to the correct French phrase for copying a file
path (e.g., "Copier le chemin du fichier" or equivalent), ensuring the JSON
string remains properly quoted and comma placement stays valid within the file.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 288114c7-559e-4367-ac70-17e4846ec41c
📒 Files selected for processing (8)
assets/i18n/fr/AppMenu.jsonassets/i18n/fr/Button.jsonassets/i18n/fr/Common.jsonassets/i18n/fr/Dialog.jsonassets/i18n/fr/Table.jsonassets/i18n/fr/Title.jsonassets/i18n/fr/Tooltip.jsonsrc/shared/i18n/index.ts
|
Bonjour @robinguy44 Responsable du support client chez SCANOSS. Nous voulions simplement vous remercier pour votre contribution. Nous l’avons bien reçue et prise en compte, et nous apprécions sincèrement le temps et les efforts que vous y avez consacrés :) Encore merci pour votre aide! Cordialement, |
dopicatto
left a comment
dopicatto
left a comment
There was a problem hiding this comment.
Hi @robinguy44, great work on the French translation! 🇫🇷 Just a couple of small fixes needed before we can merge:
-
assets/i18n/fr/Table.json— Remove trailing spaces from these keys:"Strength "→"Strength""Dependencies "→"Dependencies"
-
assets/i18n/fr/Common.json— There are two duplicate keys for the same translation. Please remove"PreRequiste"(line ~100) and keep only"PreRequisite":"PreRequisite": "Prérequis"
Once those are fixed we're good to go! Thanks
Done (257a0f9)! |
dopicatto
left a comment
dopicatto
left a comment
There was a problem hiding this comment.
Thanks for fixing the remaining whirlpool typos! Changes look good, approved.
3 participants
Hi,
This adds support for French language in the UI. I translated all strings based on the English folder of the latest commit.
I tested the changes locally and everything seems to work correctly.
Thanks,
Robin
Summary by CodeRabbit