feat(schema): add acknowledgement field to BOM operations#6
feat(schema): add acknowledgement field to BOM operations#6isasmendiagus wants to merge 2 commits intomainfrom
acknowledgement field to BOM operations#6Conversation
📝 WalkthroughWalkthroughThis PR updates Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
scanoss-settings-schema.json (1)
296-306: LGTM - consider extracting shared definitions.The
acknowledgementandtimestampfields are well-defined with proper types, formats, and descriptions. Thedate-timeformat is correctly specified per JSON Schema draft-07.Since these exact field definitions are repeated in
bom.include,bom.remove, andbom.replace, you could optionally extract them into a shared$defsblock to reduce duplication:♻️ Optional: Extract to $defs
{ "$defs": { "bomDecisionMetadata": { "acknowledgement": { "type": "string", "description": "Formal acknowledgement of this BOM decision, propagated to SBOM output" }, "timestamp": { "type": "string", "format": "date-time", "description": "ISO 8601 UTC timestamp recording when this BOM decision was made", "examples": ["2026-03-15T10:30:00Z"] } } } }Then reference via
"$ref": "#/$defs/bomDecisionMetadata"or spread the properties.This is optional—inline definitions are fine for readability and the current file size.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scanoss-settings-schema.json` around lines 296 - 306, Extract the duplicated "acknowledgement" and "timestamp" property definitions into a shared schema under $defs (e.g. "$defs": { "bomDecisionMetadata": { "acknowledgement": { ... }, "timestamp": { ... } } }) and replace the inline repeats in the bom.include, bom.remove, and bom.replace definitions with a $ref to "#/$defs/bomDecisionMetadata" (or reference individual properties from that $defs entry) so the schema reuses a single source of truth for those fields.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@scanoss-settings-schema.json`:
- Around line 296-306: Extract the duplicated "acknowledgement" and "timestamp"
property definitions into a shared schema under $defs (e.g. "$defs": {
"bomDecisionMetadata": { "acknowledgement": { ... }, "timestamp": { ... } } })
and replace the inline repeats in the bom.include, bom.remove, and bom.replace
definitions with a $ref to "#/$defs/bomDecisionMetadata" (or reference
individual properties from that $defs entry) so the schema reuses a single
source of truth for those fields.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a47aa812-3604-4959-a0c6-3a235db82b77
📒 Files selected for processing (1)
scanoss-settings-schema.json
Summary by CodeRabbit
New Features
Documentation