Fixes a bug where a blob couldn't be matched against twice.#2
Open
MicahZoltu wants to merge 1 commit into
Open
Fixes a bug where a blob couldn't be matched against twice.#2MicahZoltu wants to merge 1 commit into
MicahZoltu wants to merge 1 commit into
Conversation
The `ByteBuffer` `bb` here may be used multiple times. The first time it is used, `bb` will correctly write out to the array `b`. However, the second time it is used the buffer will already be fully read so `b` will be a zero length array with nothing in it. By flipping the ByteBuffer after use, we are able to use it over and over again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ByteBufferbbhere may be used multiple times. The first time it is used,bbwill correctly write out to the arrayb. However, the second time it is used the buffer will already be fully read sobwill be a zero length array with nothing in it. By flipping the ByteBuffer after use, we are able to use it over and over again.Fixes #1