Bjdooks/fixes 20feb2024 v2 #132
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sched_setattr() call returns -1 and sets errno to the error code for the failure. Print errno to provide more info than just -1 for the failure. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
If calibrate_cpu_cycles() fails, then it returns 0 and this value is used to calculate other information and thus will fail with an divide-by-zero error further along. Exit out here if it returns 0.
The rtapp_sleep case is not correctly intended in the run_event code. Fix this annoyance by indeting it correctly. Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some bugfixes on error return from calibration, and the wrong error code from sched_setattr.
Fix a indentation issue on rtapp_sleep