Alter the PointcutInterface::matchesMethod to include the ClassReflectio...#13
Alter the PointcutInterface::matchesMethod to include the ClassReflectio...#13rande wants to merge 1 commit intoschmittjoh:masterfrom
Conversation
…tion instance The current PointcutInterface methods signature is only valid if one Pointcut handle one class. However if a Pointcut is implemented to handle more than one class then the model is broken. The MethodReflection contains the class where the method is defined and not the class referenced in a sub type class. So this patch solves the issue by providing the ReflectionClass targetted by the configuration.
|
I'm wondering if we could make this BC by adding a second interface instead of changing the current interface? |
|
The current method signature is broken. Adding a new interface will more confusing than solving the initial issue. |
|
I don't think that it is broken, but it has limitations if you depend on I'd suggest we deprecate it, and add another interface, If you try to follow semantic versioning, a BC break would mean a 2.0 On Thu, Sep 6, 2012 at 5:58 PM, Thomas notifications@github.com wrote:
|
|
Well, It is a good day for release ;) I will see how to do so, but this will not be before a few days. |
|
@schmittjoh I can start to work on this PR again. I will move the code to an |
|
Yes, sounds good. |
3 participants
...n instance
The current PointcutInterface methods signature is only valid if one Pointcut
handle one class. However if a Pointcut is implemented to handle more than
one class then the model is broken. The MethodReflection contains the class
where the method is defined and not the class referenced in a sub type class.
So this patch solves the issue by providing the ReflectionClass targetted by
the configuration.