chore: park held durable-workflows changesets so publish can run - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the release run failed
Run 30537856951 errored with
No commits between main and changeset-release/mainand never reached publish. Cause:changesets/actiondecides "version PR vs publish" by checking whether any changeset files exist — it does not account for theignorelist. The two helddurable-workflowschangesets made it take the version-PR path,changeset versionproduced no changes (only ignored-package changesets remain), and creating the empty PR failed.Nothing was lost:
mainalready hasdurable-isolates@0.1.0versioned with its CHANGELOG from Version Packages (#5) — only the npm publish is missing.What
Move the two held changesets (
engine-runtime,workflow-authoring-surface) to a new.changeset-held/directory (with a README explaining the convention). They can't go in a.changeset/subdirectory — changesets treats directories there as its legacy v1 format and crashes.changeset statusnow reports zero pending changesets, so the push tomainfrom this PR makes the release action go straight tochangeset publish, publishingdurable-isolates@0.1.0via OIDC.durable-workflowsstays at 0.0.0 (matches npm, ignored — skipped).When durable-workflows is ready
Move the held files back into
.changeset/and removedurable-workflowsfromignorein the same PR.