fix: add mc8yp-no-sandbox header/query to disable server-mode sandbox - #50
Closed
schplitt wants to merge 1 commit into
Closed
fix: add mc8yp-no-sandbox header/query to disable server-mode sandbox#50schplitt wants to merge 1 commit into
schplitt wants to merge 1 commit into
Conversation
Mirrors the existing mc8yp-no-mcp opt-out: a connection can now disable the scratch sandbox workspace entirely instead of only relying on the implicit CLI-mode absence.
3 tasks
Owner
Author
|
Superseded by #51 — flipping the sandbox to disabled-by-default with an opt-in header made this opt-out mechanism obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sandboxworkspace, mirroring the existingmc8yp-no-mcpopt-out:mc8yp-no-sandboxheader ornoSandboxquery param (empty,*, ortrue).src/index.tsintoctx.custom.noSandbox, and read at thebuildSandboxApicall site insrc/codemode/execute.ts— opted-out sessions get nosandboxglobal at all, same as CLI mode.Test plan
pnpm test:run— added coverage intest/restrictions.test.ts(source collection + parsing) andtest/excute.test.ts(sandbox global absent when opted out)pnpm lint:fixpnpm typecheck