Fix unreachable error-type assertions in size-check tests - #4
Merged
Conversation
The errors.Is checks in the key/tweak size-validation subtests were nested
inside the "if err == nil" branch and placed after t.Fatal, making them dead
code. As a result the tests only verified that an error was returned, never
that it was the correct type. Move each assertion out so it runs against the
returned (non-nil) error.
Also change TweakSizeError to be returned as a value (TweakSizeError{}) rather
than via new() (a pointer), consistent with KeySizeError. This is required for
errors.Is to match: two distinct *TweakSizeError pointers are never ==, so the
now-live tweak assertions would otherwise always fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The errors.Is checks in the key/tweak size-validation subtests were nested inside the "if err == nil" branch and placed after t.Fatal, making them dead code. As a result the tests only verified that an error was returned, never that it was the correct type. Move each assertion out so it runs against the returned (non-nil) error.
Also change TweakSizeError to be returned as a value (TweakSizeError{}) rather than via new() (a pointer), consistent with KeySizeError. This is required for errors.Is to match: two distinct *TweakSizeError pointers are never ==, so the now-live tweak assertions would otherwise always fail.