Validate buffer sizes and overlap in Encrypt/Decrypt - #5
Merged
Conversation
The block methods indexed src/dst directly with no bounds or overlap checks, so
a short buffer produced an opaque "slice bounds out of range" panic and invalid
partial overlap went undetected. Follow the standard-library crypto/cipher.Block
convention (as in crypto/aes and crypto/des): panic with clear messages when the
input or output is not a full block, and reject inexact buffer overlap.
Add an unexported inexactOverlap helper copied from the stdlibs
crypto/internal/fips140/alias (not importable externally; also present in
golang.org/x/crypto/internal/alias). Exact overlap (in-place operation) remains
allowed, matching the existing in-place Decrypt usage.
Add TestThreefish{256,512,1024}Panics covering short input, short output, and
inexact overlap for both Encrypt and Decrypt, plus a check that in-place
operation does not panic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The block methods indexed src/dst directly with no bounds or overlap checks, so a short buffer produced an opaque "slice bounds out of range" panic and invalid partial overlap went undetected. Follow the standard-library crypto/cipher.Block convention (as in crypto/aes and crypto/des): panic with clear messages when the input or output is not a full block, and reject inexact buffer overlap.
Add an unexported inexactOverlap helper copied from the stdlibs crypto/internal/fips140/alias (not importable externally; also present in golang.org/x/crypto/internal/alias). Exact overlap (in-place operation) remains allowed, matching the existing in-place Decrypt usage.
Add TestThreefish{256,512,1024}Panics covering short input, short output, and inexact overlap for both Encrypt and Decrypt, plus a check that in-place operation does not panic.