Fix cbDest argument of StringCbPrintfW#203
Open
topolarity wants to merge 1 commit intosciapp:developfrom
Open
Conversation
topolarity
commented
Feb 26, 2026
| They are searched in that order. | ||
| Use AddDllDirectory to add additional user directories to the search. | ||
| */ | ||
| handle = LoadLibraryExW(w_pathname, NULL, LOAD_LIBRARY_SEARCH_DEFAULT_DIRS); |
Contributor
Author
There was a problem hiding this comment.
It is unusual to call LoadLibraryExW with an absolute path and the LOAD_LIBRARY_SEARCH_DEFAULT_DIRS flag, since no searching is done for an absolute path (regardless of flags).
Should this be:
Suggested change
| handle = LoadLibraryExA(pathname, NULL, LOAD_LIBRARY_SEARCH_DEFAULT_DIRS); |
?
Microsoft has documented that this is the size of the destination buffer in bytes, not characters. PATH_MAX is already limited to 260 on Windows, so this mistake means that paths longer than ~130 characters are truncated.
topolarity
force-pushed
the
ct/fix-path-append
branch
from
8df06d4 to
0364ffe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Microsoft has documented that this is the size of the destination buffer in bytes, not characters:
PATH_MAX is already limited to 260 on Windows, so this mistake means that paths longer than ~130 characters are truncated.