Fix: drop magnus "embed" feature (precompiled darwin libruby link)#21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
embedfeature on the magnus dependency expands torb-sys/link-ruby, which makes rb-sys link the build machine's shared libruby by ABSOLUTE path instead of using the default-undefined dynamic_lookup. On the CI runner (ruby/setup-ruby,--enable-shared) that baked/Users/runner/hostedtoolcache/Ruby/<v>/arm64/lib/libruby.X.dylibinto the precompiled arm64-darwin bundle, so it failed to load on any other Mac (confirmed viaotool -L).embedis only for embedding Ruby in a standalone Rust binary, never for an extension cdylib. Dropping it restores dynamic_lookup so Ruby symbols resolve from the host process at load time. Validated against tokenkit (no embed -> portable). Released first as a prerelease for smoke-testing on Mac + Linux.