Skip to content

chore: fix stale linux-cross-image-repo comments #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xrl merged 1 commit into from
Jun 19, 2026
Merged

chore: fix stale linux-cross-image-repo comments #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,13 @@ name: Release
# FULL LINUX PRECOMPILED SUPPORT (x86_64-linux + aarch64-linux):
# parsekit's native extension builds MuPDF (mupdf-sys, from C source) and, via
# tesseract-rs 0.2's bundled build, Tesseract 5.3.4 + Leptonica 1.84.1 from
# source. The stock rb-sys-dock cross image (rbsys/<platform>:0.9.128) carries
# source. The stock rb-sys-dock cross image (rbsys/<platform>:<tag>) already carries
# cmake + clang/libclang (all mupdf-sys + the bundled C++ build need) and the
# rb-sys-dock container has network egress for tesseract-rs's source-zip
# downloads — so both linux legs build against the DEPS-ENRICHED cross image
# pre-seeded by linux-cross-image-repo below (FROM rbsys/<platform>:0.9.128,
# plus the union apt deps incl. leptonica/tesseract dev libs for forward-compat
# with a future system-tesseract path). The :0.9.128 image tag is load-bearing:
# ext/parsekit/Cargo.lock pins rb-sys to 0.9.128 so rb-sys-dock derives exactly
# that image name and finds our pre-seeded image locally (skipping its own pull).
# rb-sys-dock container has network egress for tesseract-rs's source-zip downloads —
# so the linux leg needs NO extra system deps and we pass NO linux-image-setup input:
# the leg builds directly against the stock cross image, with everything compiled from
# source inside it. ext/parsekit/Cargo.lock pins rb-sys, which fixes the
# rbsys/<platform>:<tag> base image rb-sys-dock derives.
#
# RUNTIME NOTE (carried forward, not solved here): the precompiled gem does NOT
# bundle eng.traineddata, so OCR at runtime needs system tessdata reachable via
Expand Down