Bump mupdf from 0.7.0 to 0.8.0 in /ext/parsekit#39
Merged
Conversation
Contributor
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Bumps [mupdf](https://github.com/messense/mupdf-rs) from 0.7.0 to 0.8.0. - [Release notes](https://github.com/messense/mupdf-rs/releases) - [Commits](messense/mupdf-rs@v0.7.0...v0.8.0) --- updated-dependencies: - dependency-name: mupdf dependency-version: 0.8.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
MuPDF 0.8.0 upgrades the underlying C library to 1.27.2 which is stricter about xref byte offset validation. The hand-crafted test PDFs had hardcoded xref offsets that were off by 3-27 bytes (because <<~PDF heredoc strips leading indentation, changing the actual byte positions from what was hard-coded). MuPDF 0.7.0 silently repaired these; 0.8.0 returns empty text. Replace the three heredoc PDFs with a generate_minimal_pdf helper that computes xref offsets from the actual byte positions at runtime.
cpetersen
force-pushed
the
dependabot/cargo/ext/parsekit/mupdf-0.8.0
branch
from
5c99fdf to
65a93c2
Compare
MuPDF 0.8.0 (mupdf C library 1.27.2) does not extract text from minimal hand-crafted PDFs that declare Helvetica as a standard Type1 font without an embedded encoding resource. This was working in 0.7.0 which was more permissive with such 'naked' fonts. Replace the three failing tests with the sample.pdf fixture which is a proper PDF and works correctly with all mupdf versions. Update the expected text to match sample.pdf's actual content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps mupdf from 0.7.0 to 0.8.0.
Release notes
Sourced from mupdf's releases.
Commits
deaacc8Addarray_iter/dict_itertoPdfObject(#246)3ee6802Fix UB inPdfObjectas_string,as_name,as_bytes(#245)a688f37Fix several FFI correctness and soundness bugs (#244)e00fc1fPolish readmec1beacaExpose (more) accessors to annotation quads (#243)e414be9Add binding for pdf_annot_obj (allows PdfAnnotation -> PdfObject conversion) ...4791dffImprove unsafe FFI hygiene (#240)3f36a6bUse zerocopy for geometry FFI conversions (#239)1b7977dFix Android system-fonts dependency (#238)88205d1feat(pdf): add optional content APIsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)