Use GitHub App token for vendorHash auto-fix workflow#251
Merged
Conversation
The previous attempt pushed corrective commits using GITHUB_TOKEN and re-triggered the test workflow via workflow_dispatch. That dispatch ran, but verified empirically on PR #248: workflow_dispatch check_runs are excluded from the PR's statusCheckRollup, so the merge box still showed no checks even though the run was on the PR HEAD SHA. This is a known GitHub limitation (https://stackoverflow.com/q/74722061, https://github.com/orgs/community/discussions/24616). Switch to the pattern peter-evans/create-pull-request, DeterminateSystems' update-flake-lock and Mic92/nix-update converge on: push the corrective commit using a GitHub App token. The non-GITHUB_TOKEN identity makes the push fire pull_request synchronize naturally, producing a check_suite the PR UI displays. Drop the workflow_dispatch indirection from test.yaml. Also widen scope from Renovate-authored branches to any same-repo PR, matching the canonical published recipe in peter-evans/create-pull-request docs (autopep8 example). Per the GitHub Security Lab guidance the same-repo filter is the security boundary; the renovate/ prefix was just a noise/scope gate.
eseliger
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous attempt pushed corrective commits using
GITHUB_TOKENand re-triggered the test workflow viaworkflow_dispatch. That dispatch ran, but verified empirically on #248:workflow_dispatchchecks are excluded from the PR's status, so the merge box still showed no checks even though the run was on the PR HEAD SHA.New behavior: push the corrective commit using a GitHub App token. The non-
GITHUB_TOKENidentity makes the push firepull_requestsynchronize naturally, triggering checks the PR UI displays.Also widen scope from Renovate-authored branches to any same-repo PR.