Remove support for legacy jUnit 4 Spock Groovy tests#611
Merged
Conversation
All tests have been migrated to jUnit 5 Kotlin or Java
This utilizes the test view of IntelliJ instead of just giving simple Maven output.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes remaining support code for legacy JUnit 4 / Spock (Groovy) tests and aligns the test setup documentation and IDE run configurations with the JUnit 5-based test infrastructure used in this repository.
Changes:
- Migrates the remaining JUnit 4-style
assertThrowsusage in Kotlin tests to JUnit 5’s Kotlin-friendlyassertThrows. - Removes Spock/JUnit 4 scenario-suite infrastructure and Groovy base specification classes from
src/test. - Updates testing documentation and replaces an IntelliJ Maven test run configuration with a JUnit run configuration excluding
nightlytests.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/kotlin/sirius/kernel/nls/FormatterTest.kt | Switches assertThrows to JUnit 5 Kotlin API usage. |
| src/test/java/sirius/kernel/SiriusExtension.java | Cleans up Javadoc to match removed scenario-suite support. |
| src/test/java/sirius/kernel/ScenarioSuite.java | Removes legacy JUnit 4 / Spock-based scenario suite runner. |
| src/test/java/sirius/kernel/Scenarios.java | Removes legacy scenario annotation container. |
| src/test/java/sirius/kernel/Scenario.java | Removes legacy scenario annotation. |
| src/test/java/sirius/kernel/BaseSpecification.groovy | Removes Spock base specification class. |
| README.md | Documents SiriusExtension as the preferred way to run framework-backed tests. |
| .run/test.run.xml | Adds IntelliJ JUnit run configuration excluding nightly tests. |
| .run/mvn clean test - without nightly.run.xml | Removes IntelliJ Maven run configuration previously used to exclude nightly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jakobvogel
approved these changes
May 26, 2026
ymo-sci
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE
Details
All tests have been migrated to jUnit 5 Kotlin or Java
Additional Notes
Checklist