Adds ifFilled utility method to Strings#618
Merged
Merged
Conversation
Provides a convenient way to execute a consumer if the string representation of an object is non-empty. Includes comprehensive test coverage. Fixes: OX-12357
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a small utility to Strings to execute a callback only when an input value is considered “filled” (non-null and non-empty via toString()), with accompanying unit tests to validate the new behavior.
Changes:
- Added
Strings.ifFilled(@Nullable Object, Consumer<String>)helper. - Added Kotlin tests covering
ifFilledbehavior for filled/empty/null values.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/sirius/kernel/commons/Strings.java | Introduces the ifFilled utility method using isFilled to guard callback execution. |
| src/test/kotlin/sirius/kernel/commons/StringsTest.kt | Adds unit tests for the new Strings.ifFilled method across several input types. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fhaScireum
approved these changes
Jun 24, 2026
sabieber
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional Notes
Checklist