Upgrade jackson from 2.22.0 to 3.2.0#1677
Open
sabieber wants to merge 1 commit into
Open
Conversation
Renames all imports from com.fasterxml.jackson to the new tools.jackson packages; annotations remain on the 2.x line. Applies the accompanying API renames: JsonProcessingException becomes the unchecked JacksonException and the text accessors are replaced by their string counterparts (asText() -> asString()). No structural or behavioral changes are required as the shared object mapper in sirius-kernel retains its Jackson 2 compatible configuration. Assisted-by: Claude Fable 5 Fixes: SIRI-1149
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request migrates sirius-web to Jackson 3 APIs as part of the wider stack upgrade (new tools.jackson.* packages and renamed tree/node accessors), keeping the codebase compiling and tests aligned with the new API surface.
Changes:
- Updated Jackson imports from
com.fasterxml.jackson.*totools.jackson.*in main and test code. - Migrated
JsonNodestring extraction fromasText()toasString()in Kotlin tests and OAuth JSON parsing. - Updated JSON pretty-print error handling to catch
JacksonExceptioninstead ofJsonProcessingException.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/test/kotlin/sirius/web/util/CaptchaControllerTest.kt | Updates JSON node string accessors to Jackson 3 (asString). |
| src/test/kotlin/sirius/web/http/WebServerTest.kt | Updates JSON assertions to use asString throughout. |
| src/test/kotlin/sirius/web/http/WebServerNightlyTest.kt | Updates JSON assertion to use asString. |
| src/test/kotlin/sirius/web/health/ConsoleControllerTest.kt | Migrates JsonPointer import to Jackson 3 package. |
| src/test/java/sirius/web/service/JSONStructuredOutputTest.java | Migrates Jackson tree node imports to tools.jackson. |
| src/test/java/sirius/web/http/TestResponse.java | Migrates ObjectNode import to tools.jackson. |
| src/test/java/sirius/web/http/TestRequest.java | Migrates ObjectNode import to tools.jackson. |
| src/main/java/sirius/web/templates/pdf/TagliatellePdfViaGotenbergChromiumContentHandler.java | Migrates ObjectNode import to tools.jackson. |
| src/main/java/sirius/web/services/JSONStructuredOutput.java | Migrates JsonNode import to tools.jackson. |
| src/main/java/sirius/web/services/JSONCall.java | Updates exception type to JacksonException and migrates node imports. |
| src/main/java/sirius/web/security/oauth/ReceivedTokens.java | Migrates ObjectNode import and asText → asString token parsing. |
| src/main/java/sirius/web/security/oauth/OAuthAuthentication.java | Migrates ObjectNode import and asText → asString error parsing. |
| src/main/java/sirius/web/http/WebContext.java | Migrates ObjectNode import to tools.jackson. |
| src/main/java/sirius/pasta/noodle/macros/JsonMacro.java | Migrates ObjectNode import to tools.jackson. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
idlira
approved these changes
Jul 13, 2026
mkeckmkeck
approved these changes
Jul 14, 2026
jakobvogel
approved these changes
Jul 15, 2026
ymo-sci
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES
Upgrades Jackson from 2.22.0 to 3.2.0 across the sirius stack. Jackson 3 uses new Maven coordinates and Java packages — see the official Jackson 3 migration guide and release notes for the complete list of renames and behavioral changes.
What applications using the sirius framework have to change:
com.fasterxml.jackson.*→tools.jackson.*(annotations stay oncom.fasterxml.jackson.annotation); dropjackson-datatype-jsr310andJavaTimeModuleregistrations (built-in now).JsonProcessingException→JacksonException, deadcatch (IOException)blocks), method renames (asText()→asString()etc.,writeFieldName()→writeName()etc.), builder-based mapper/generator configuration — see the migration guide for details.Additional Notes
Checklist