Skip to content

Refactor typing - #31

Draft
scolby33 wants to merge 4 commits into
developfrom
refactor_typing
Draft

Refactor typing#31
scolby33 wants to merge 4 commits into
developfrom
refactor_typing

Conversation

@scolby33

Copy link
Copy Markdown
Owner
  • Split the API functionality into separate mixin-ish classes based on their organization in the Pushover documentation
  • Add missing/new API's
  • Add type hints
  • Update the documentation to handle the new type hints and argument passing style, including good examples of usage and reasonable sectioning of the functionality

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.87179% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.04%. Comparing base (e46b107) to head (8cf68e8).

Files with missing lines Patch % Lines
src/pushover_complete/message_api.py 93.10% 3 Missing and 1 partial ⚠️
src/pushover_complete/licensing_api.py 81.25% 2 Missing and 1 partial ⚠️
src/pushover_complete/groups_api.py 95.00% 2 Missing ⚠️
src/pushover_complete/subscription_api.py 92.30% 1 Missing and 1 partial ⚠️
src/pushover_complete/receipt_and_callback_api.py 96.96% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #31      +/-   ##
===========================================
- Coverage   100.00%   95.04%   -4.96%     
===========================================
  Files            3       10       +7     
  Lines           97      242     +145     
  Branches         8       14       +6     
===========================================
+ Hits            97      230     +133     
- Misses           0        9       +9     
- Partials         0        3       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants