Hundle slash and correct options variables#2
Open
AnouarBe wants to merge 2 commits intoscottlu:masterfrom
Open
Hundle slash and correct options variables#2AnouarBe wants to merge 2 commits intoscottlu:masterfrom
AnouarBe wants to merge 2 commits intoscottlu:masterfrom
Conversation
added 2 commits
March 2, 2013 21:40
+ Added some comments + Changed some parameters to be more explicit + Add the use of the module argparse + Add --exclude option to exclude dirs from the backup
- Corrected the bug caused by the - with options (replace it with _) - Used a hash instead of a Namespace for the ARGS variable - Corrected the bug which doesn't allow to backup / correctly
|
@AnouarBe would you mind to split up your pull request so one is a minimal change that fixes only the problem, and the other(s) add comments, etc? it might distract or make it difficult to understand if you want to handle directories starting with a slash, and the commit then changes option variables. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I discovered a bug when trying to backup the / , for example : /home/dir is stored in the tree as "ome/dir" without the "h".
I corrected a mistake when using options with argparse, options like ssh-C should be used in the script like this ssh_C.
I added some explicit comments to help me to understand some verbose message.