fix: record slack enqueue outcome in webhook history#171
Open
i-am-thor[bot] wants to merge 2 commits into
Open
fix: record slack enqueue outcome in webhook history#171i-am-thor[bot] wants to merge 2 commits into
i-am-thor[bot] wants to merge 2 commits into
Conversation
Co-authored-by: Son Dao <son.dao@katalon.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Slack webhook history accuracy by recording enqueue outcomes only after the queue operation completes, so failed queue writes are no longer represented like successfully routed events.
Changes:
- Preserves
enqueue_failedhistory reasons through the webhook history error wrapper. - Records successful Slack enqueue metadata after enqueue completion.
- Adds regression tests for pending-privacy and cached public-channel enqueue failure history.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/gateway/src/app.ts |
Updates Slack enqueue handling to distinguish succeeded vs failed enqueue history metadata. |
packages/gateway/src/app.test.ts |
Adds coverage for successful pending privacy history and enqueue failure history cases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Move enqueue-failure recording into the shared enqueueSlackEvent wrapper instead of duplicating try/catch in both defer and accept paths. Drop the attemptedCorrelationKey rename and redundant enqueueStatus field; reason already distinguishes success from enqueue_failed. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
AI-generated — verify before acting. View Thor context