Skip to content

WIP Fix redirection bug. #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rmax wants to merge 2 commits into from
Closed

WIP Fix redirection bug. #261

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf0869f
WIP Fix redirection bug.
rmax Feb 10, 2017
dcd2963
Remove is-redirected check.
rmax Feb 22, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions frontera/contrib/scrapy/schedulers/frontier.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,9 @@ def from_crawler(cls, crawler):
return cls(crawler)

def enqueue_request(self, request):
if not self._request_is_redirected(request):
self.frontier.add_seeds([request])
self.stats_manager.add_seeds()
return True
elif self.redirect_enabled:
self._add_pending_request(request)
self.stats_manager.add_redirected_requests()
return True
return False
self._add_pending_request(request)
self.stats_manager.add_redirected_requests()
Copy link
Copy Markdown
Member

@sibiryakov sibiryakov Feb 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that line is wrong, otherwise LGTM.

return True

def next_request(self):
request = self._get_next_request()
Expand Down Expand Up @@ -166,9 +160,6 @@ def _get_exception_code(self, exception):
except:
return '?'

def _request_is_redirected(self, request):
return request.meta.get(b'redirect_times', 0) > 0

def _get_downloader_info(self):
downloader = self.crawler.engine.downloader
info = {
Expand Down