Revert "Fixed scheduler process_spider_output() to yield requests"#273
Closed
voith wants to merge 1 commit intoscrapinghub:masterfrom
Closed
Revert "Fixed scheduler process_spider_output() to yield requests"#273voith wants to merge 1 commit intoscrapinghub:masterfrom
voith wants to merge 1 commit intoscrapinghub:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
=======================================
Coverage 70.09% 70.09%
=======================================
Files 68 68
Lines 4721 4721
Branches 633 633
=======================================
Hits 3309 3309
Misses 1272 1272
Partials 140 140
Continue to review full report at Codecov.
|
Member
|
This is not needed, let's better fix request enqueueing. |
Member
|
see this #261 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #254
In accordance to #254 (comment)