Skip to content

Make ZYTE_API_ENABLED=False disable the add-on too - #324

Merged
wRAR merged 1 commit into
scrapy-plugins:mainfrom
AdrianAtZyte:disabled-zyte-api-addon
Sep 1, 2026
Merged

Make ZYTE_API_ENABLED=False disable the add-on too#324
wRAR merged 1 commit into
scrapy-plugins:mainfrom
AdrianAtZyte:disabled-zyte-api-addon

Conversation

@AdrianAtZyte

Copy link
Copy Markdown
Contributor

Proposed by @VMRuiz so that, when you set ZYTE_API_ENABLED=False to temporarily disable the add-on, you don’t get the download handlers installed anyway.

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.04%. Comparing base (197d22c) to head (9d876d6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
+ Coverage   97.79%   98.04%   +0.25%     
==========================================
  Files          15       15              
  Lines        2407     2409       +2     
  Branches      439      440       +1     
==========================================
+ Hits         2354     2362       +8     
+ Misses         26       20       -6     
  Partials       27       27              
Files with missing lines Coverage Δ
scrapy_zyte_api/addon.py 95.91% <100.00%> (+0.17%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AdrianAtZyte
AdrianAtZyte marked this pull request as ready for review August 25, 2026 11:17
@wRAR
wRAR merged commit 07ad7d8 into scrapy-plugins:main Sep 1, 2026
59 of 64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants