feat(gate): add canonical policy resolution - #452
Merged
Merged
Conversation
screenleon
marked this pull request as ready for review
July 28, 2026 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause and impact
The policy coordinates were previously resolved across multiple consumers, allowing tier, reviewer coverage, pass kind, and execution mode to drift. The new resolver owns those coordinates once and records the decision in verified assurance.
A separate full-suite failure exposed a detached-readiness race: after supervisor identity became temporarily unobservable, the launcher allowed only five 50 ms polls before reporting early death. Under concurrent load this produced false failures. The configured readiness timeout now owns the complete evidence window, while genuine timeout and early-exit paths remain fail-closed.
Validation
tests/bin/run-all-tests.sh --jobs 4 --result-file /tmp/cc513-parallel-full-199d42f.json199d42fbd7f78a45d9481a82da3ef657aeb0f9df6017f07cb1bf71e464598d0536a6d8758094db8df9a2b2411caa51f7c9312365tests/bin/run-tests.sh --verify-full /tmp/cc513-parallel-full-199d42f.jsonop-20260728T051940Z-be5f23gate-20260728-051940-8f99abReview note
The user explicitly selected sequential execution to control reviewer-session token cost. Policy recommended parallel for this large cross-boundary change, but explicit mode is a user-owned cost and independence choice; the assurance records that override, and reviewer coverage remained complete.
An earlier run,
gate-20260728-051821-11466c, failed before reviewer dispatch because the injected preflight result sink conflicted with a--verify-fullinvocation. It consumed no reviewer session and is superseded by the verified GO run above.Follow-ups
.gate-overrides.md/--override-filesymlink handling under an explicit compatibility contractTracking: CC-513