fix(gate): cancel foreground producer process trees - #453
Merged
Conversation
screenleon
marked this pull request as ready for review
July 28, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
pmctl gate cancelpreviously traversed only recorded reviewer child runs. During foreground preflight, the parent operation already existed but no reviewer child had been attached, so cancellation could terminalize the operation while the preflight producer process tree continued running.Verification
op-20260728T072646Z-01ef21completed with 0 unresolved children/home/screenleon/.local/share/pm-dispatch/state/projects/4633b7e7f780014195b603f84ce281c3a1afd97b/runs/gate-20260728-162646-1419363/.gate-results/gate-20260728-162657.md.pm-dispatch/test-results/latest-full.jsond9759688023394fa8417a8f4e83093e147d3097925c0fab00014f164b5a10197test-pmctl-gate44/44,test-pmctl-operation17/17,test-pr-gate194/194,test-core-schemas73/73